search

globaldothealth / monkeypox

Mpox 2022 repository
Other
175 stars 36 forks source link

Gh file download #196

Closed jim-sheldon closed 1 year ago

jim-sheldon commented 1 year ago

Not done yet, but would not mind eyes sooner for a faster merge. The case.py file should become its own package so we can import it.

jim-sheldon commented 1 year ago

Taking this out of draft with the caveats that I will add error handling, ensure tests pass, and squash/fixup commits before merging.

jim-sheldon commented 1 year ago

Unless there are any blockers, I would like to punt on addressing comments until a future PR, so I can get it up and running ASAP. Refinements should happen but barring anything glaring I think can wait until after crunch time.

jim-sheldon commented 1 year ago

Few changes, otherwise looks good -- are we going to deprecate src/app.py? Looks like this will do most of the work, minus the aggregation into total counts.

Yeah, we should be able to move everything into the scripts folder.