Git version of txtorcon causes TypeError

[djon3s]

If we install the latest git version of txtorcon (pip install git+https://github.com/meejah/txtorcon.git) apaf fails to start. Txtorcon is being passed a 'None' type for the data-directory.

Isis recently reported an issue in txtorcon and it might have something to do with that (https://github.com/meejah/txtorcon/issues/15)

I tried this with both the master branch and the issue-15 branch of txtorcon. (the version pip installs on 'pip install txtorcon' which is txtorcon 0.5.*? works fine) Link to branch referred to is here https://github.com/meejah/txtorcon/issues/15 Also tried master. python apaf/main.py 2012-09-17 20:32:02+1000 [-] Log opened. 2012-09-17 20:32:02+1000 [-] Application starting on 5672 2012-09-17 20:32:02+1000 [-] Starting factory <cyclone.web.Application instance at 0x26e90e0> 2012-09-17 20:32:02+1000 [-] Site starting on 6067 2012-09-17 20:32:02+1000 [-] Starting factory <twisted.web.server.Site instance at 0x32aca70> 2012-09-17 20:32:02+1000 [-] 'Cannot import service zinniablog' 2012-09-17 20:32:02+1000 [-] Traceback (most recent call last): 2012-09-17 20:32:02+1000 [-] File "apaf/main.py", line 48, in 2012-09-17 20:32:02+1000 [-] main() 2012-09-17 20:32:02+1000 [-] File "apaf/main.py", line 31, in std_main 2012-09-17 20:32:02+1000 [-] base.main().addCallback(base.setup_complete).addErrback(base.setup_failed) 2012-09-17 20:32:02+1000 [-] File "/home/lovelace/src/python/APAF/apaf/../apaf/run/base.py", line 71, in main 2012-09-17 20:32:02+1000 [-] tor_binary=config.tor_binary, 2012-09-17 20:32:02+1000 [-] TypeError: launch_tor() got an unexpected keyword argument 'data_directory' I'd figure out a solution, but I am not very familiar with the codebase yet, so I thought it was safer to report. If it turns out either of the patches at https://github.com/meejah/txtorcon/issues/15 solve this, this can be closed.

[meejah]

With the issue-15 branch, instead of passing data_directory=foo to launch_tor just set config.DataDirectory=foo before calling launch_tor(). I will be doing the same for control_port -- that is, passing options inside the config will be the preferred way to do it.

Does this make sense of APAF? If you prefer the keyword method, I could make both work; I figured one way to do it might be better long-term.

[fpietrosanti]

cc @maker for meejah

djons, when reporting bug pls apply "Bug" tag.

[mmaker]

That's ok to change APAF for supporting it, thanks @meejah :)

[meejah]

p.s. I've merged issue-15 to master so if master doesn't work for you still either comment here or open a new bug; if it does ork, can you close this? Thanks!