search

globaleaks / GlobaLeaks

GlobaLeaks is free, open source software enabling anyone to easily set up and maintain a secure whistleblowing platform.
https://www.globaleaks.org
Other
1.21k stars 263 forks source link

Reminder dates change by themselves to 1/1/1970 #4121

Open elbill opened 4 weeks ago

elbill commented 4 weeks ago

What version of GlobaLeaks are you using?

4.15.6

What browser(s) are you seeing the problem on?

All

What operating system(s) are you seeing the problem on?

Windows

Describe the issue

Some reminder dates with open status change by themselves to 1/1/1970. The default reminder interval is 90 days.

Proposed solution

No response

evilaliv3 commented 2 weeks ago

Thank you @elbill

You are right, we decided to reset the reminder date as soon that one recipient check the report since the reminder date, but instead of resetting it we are setting it to a wrong timing and so the reminder is remaining active.

I'm going to issue a patch and include it in a minor release for version 4.

elbill commented 2 weeks ago

Thanks. what is the point of resetting the reminder date? What kind of reset are we talking about (disable)? If the recipient missed their deadline, they check the report for what needs to be done but may not take action immediately. Then resetting can be confusing. I understand that people may not reset the reminders but missing one may cause more problems.

evilaliv3 commented 2 weeks ago

Many clients of other community members got confused of receiving too many emails of reminder; this was reported for example to @larrykind and @gfraschini

For this reason we decided to disable the reminder automatically when a recipient access a report after the reminder date.

This behaviour is considered particular important when you have one recipient only taking care of the reports on behalf of a team. The typical user seems to prefer that the reminder is disabled as soon that they open the report since the reminder date passes.