globaleaks / globaleaks-whistleblowing-software

GlobaLeaks is a free and open-source whistleblowing software enabling anyone to easily set up and maintain a secure reporting platform.
https://www.globaleaks.org
Other
1.25k stars 274 forks source link

Accessibility issues version 4.9.5 in relation to WCAG 2.1 conformity #3222

Closed larrykind closed 2 years ago

larrykind commented 2 years ago

We noted some accessibility problems, reference is https://www.w3.org/TR/WCAG21.

evilaliv3 commented 2 years ago

Thank you @larrykind.

The suggestion are surely good but miss proper detail. If you can please list the pages that have issues and the suggestion that you think should be applied; Alternatively if you have the possibility i invite you to perform a pull request directly to propose your changes.

larrykind commented 2 years ago

@evilaliv3 below follows a more detailed analysis:


Accessibility Issues

4.1.1 Duplicate ID elements are present

Some elements have the same For example, the id #step-0-field-2-0-input-0 is repeated not less than 7 times in the tab 'Report'. The ids should be unique

4.1.2 There are buttons without text or a label

Some examples:

Therefore ensure that all buttons and interactive elements have descriptive text

4.1.2 Some form fields do not have <label> attached

All labels in the form have <label> without the <id> on the reference field

Best practices: The site does not use headings, so it is impossible to identify a title from the normal text It is therefore suggested to use tags for each title in the application.


Please tell me if you need something more specific

evilaliv3 commented 2 years ago

Thank you @larrykind.

The input is detail is helpful and perfect and i think this corrections could be issued right away.

Would you please clarify about the tools that you are using to validate the globaleaks accessibility? This would be helpful in order to validate the correction. Thank you if you could share.

evilaliv3 commented 2 years ago

@larrykind: I should have fixed all the reported issues and the corrections are going to be included in release 4.9.6

larrykind commented 2 years ago

Thanks @evilaliv3, the tool we used to this first accessibility check is Siteimprove, using browser plugin. We didn't test with a screen reader for blind people yet but we will do soon and give you a feedback.