globaleaks / globaleaks-whistleblowing-software

GlobaLeaks is a free and open-source whistleblowing software enabling anyone to easily set up and maintain a secure reporting platform.
https://www.globaleaks.org
Other
1.25k stars 274 forks source link

Language text customisation does not work with whistleblower identification question template #3666

Open elbill opened 1 year ago

elbill commented 1 year ago

What version of GlobaLeaks are you using?

4.13.11

What browser(s) are you seeing the problem on?

Chrome, Microsoft Edge

What operating system(s) are you seeing the problem on?

Windows

Describe the issue

Language text customisation overide does not work with whistleblower identification question template. Neither in english or other languages.

Proposed solution

No response

evilaliv3 commented 1 year ago

Thank you.

Yes this is a known limitation.

The language override currenty do not work for every string at the moment.

If you need to revise some translations please feel free to provide them to me and we will update them for the respective language directly on Transifex where we host the software translations

elbill commented 1 year ago

My issue is not with the translation but with the term "identification information" that sounds very intrusive I would prefer the "contact details" because you need to be able to contact them not "identify them". A good alternative would be Do you wish to provide us with your name and contact details?

evilaliv3 commented 1 year ago

What a about a more simple and direct: "Would you like to tell us who you are?"

\cc @giorgiofraschini @danielvaknine @larrykind @gianlucagilardi

larrykind commented 1 year ago

Hello, My suggestion could be a mix: "Would you provide your contact informations (or details)".

Anyway to accomplish the original task, I usually create a custom group question as a copy of the default one. That one can be translated in every language using your preferred words. And replace identity template.

My main discomfort about that translation is to redraw the entire identity template to change only the label in cases when the identity is set as mandatory: in that case the label can't be a question, but something like "Please provide your personal data".

evilaliv3 commented 1 year ago

Thank you @larrykind

The reason of my proposal is to put the attention on the reason: subscribe the report providing your identity.

I agree that we should have two different text depending on the manadatory flag, what about:

larrykind commented 1 year ago

Thank you @larrykind

The reason of my proposal is to put the attention on the reason: subscribe the report providing your identity.

I agree that we should have two different text depending on the manadatory flag, what about:

* Would you like to tell us who you are?

* Please tell us who you are

@evilaliv3 For my experience I'd like to keep a more formal relationship with the whistleblower, so following my taste I could prefer "providing" and not "telling". Thanks for considering it.

elbill commented 1 year ago

@larrykind @evilaliv3 I agree with "provide" . I will also insist it is the contact details we are after, not identity (identity is included). We do not necessarily want to know who they are but to have a more immediate and trustful communication.

evilaliv3 commented 1 year ago

Thank you all.

@elbill: The text and template is fully customable if you need to. Just use the "Template override" feature by providing the UUID of your template.

In the general text we need to keep it as is for a matter of retrocompatibility and because the main feature is about "identity".

Provide works better for contact details, but it does not work as replacement for tell in this sentences:

How would you ameliorate those without changing their meaning?

evilaliv3 commented 1 year ago

p.s. phone communication or more communication should be just a last resort; under the directive, going from a secure channel to an insecure one like email or phone is bad practice as it would not guarantee at all the protection of the identity nor the confidentiality of the fact reported.