globaleaks / globaleaks-whistleblowing-software

GlobaLeaks is a free and open-source whistleblowing software enabling anyone to easily set up and maintain a secure reporting platform.
https://www.globaleaks.org
Other
1.25k stars 274 forks source link

Update codebase to use new angular 17 standalone components and control flow #4277

Closed msmannan00 closed 1 month ago

msmannan00 commented 1 month ago
  1. Replaced deprecated control flow directives with the latest syntax.
  2. Converted components to standalone, removing NgModules.
  3. Updated route definitions with standalone component-based routing.
  4. Optimized lazy loading using new route-based syntax.
  5. Cleaned up dependencies and ensured compatibility with the latest Angular version.
codacy-production[bot] commented 1 month ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +1.16% (target: -1.00%) :white_check_mark: 93.57% (target: 70.00%)
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (842d52a355341b4b158244e56617e1eb39de6d42) | 18603 | 15144 | 81.41% | | | Head commit (9b90d95b9c0d4264548cd1d3a2adc2396184d510) | 32694 (+14091) | 26995 (+11851) | 82.57% (**+1.16%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#4277) | 824 | 771 | **93.57%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

evilaliv3 commented 1 month ago

Thank you @msmannan00

Very interesting patch. Apparently the code coverage pagges from 81.39 to 81.85 with this change.

Since you changed a very large set of files we should get sure that the files that you touched contains the updates that were included in the latest changes to the codebase in the devel branch.

evilaliv3 commented 1 month ago

@msmannan00 : This is an example of "regression" where with your proposal you are reintroducing some old code.

I will give it a try to find other situations like this.

image

msmannan00 commented 1 month ago

Yup, actually in past two weeks I tried to take merge from stable version twice and make changes accordingly but even then I might have missed some commits that were made in the week

evilaliv3 commented 1 month ago

Very good to go! Merging!