search

globaleaks / globaleaks-whistleblowing-software

GlobaLeaks is a free and open-source whistleblowing software enabling anyone to easily set up and maintain a secure reporting platform.
https://www.globaleaks.org
Other
1.25k stars 275 forks source link

Mandatory voice fields not filled do not block the saving of the report #4304

Closed maelaborazioni closed 3 days ago

maelaborazioni commented 2 weeks ago

By setting up a questionnaire with a series of questions, all of the "voice" type, all mandatory and all with a minimum length = 1, the questionnaire is still saved even if the fields are not filled in (recorded). The error messages in red under the audio recorder icon are shown but the report is saved anyway.

Edit: Found using GL 5.0.24 / Chrome / Windows 11

evilaliv3 commented 2 weeks ago

Thank you for reporting this @maelaborazioni

We will check on this an implement proper block on the submission on the report and try to ship a fix with the next minor release.

evilaliv3 commented 2 weeks ago

I think what we could do here is to verify that if the field is marked "mandatory" there should be at least a recording.

The check on the length is probably more difficult and not necessary because anyhow to save the recording the length requirement will need to be met before the user can save the file.

maelaborazioni commented 2 weeks ago

I think what we could do here is to verify that if the field is marked "mandatory" there should be at least a recording.

seems legit to me

evilaliv3 commented 2 weeks ago

@maelaborazioni : The fix to this issue has been included in current release 5.0.26.

thank you again for your feedback!

maelaborazioni commented 2 weeks ago

Amazing news. Thank you @evilaliv3 for the effort you put in and your timeliness.

evilaliv3 commented 3 days ago

Actually i had to rollback rollback the work that i made to enforce mandatory checks on file uploads and voice questions.

I will re-open a new clean ticket to keep track of the need for fixing this aspects.