Multilanguage fields fail in validation

[vecna]

Having more than one language configured, and translated fields, cause failure in validation.

This bug contains some logic bug, and need to be addressed seriously with the fields refactor (changing of the translation method, creation of the fields database, initialization with default value, etc)

At the moment a temporary solution would be provided, because this bug impair the launch of a bilingual adopter.

[vecna]

details to test the bug:

• configure two language context
• translate the fields name
• make a submission with the first language (it works)
• make a submission with the second language (it fails for two reason. missing the required field, and if you remove required fields, is unable to recognize the second language keys)

[evilaliv3]

@vecna can you describe the temporary solution you see?

[vecna]

2013-10-03 20:31:29+0200 [D] Fields proposed do not match with previous language schema (Unexpected shit) 2013-10-03 20:31:29+0200 [D] Fields proposed do not match with previous language schema (Unexpected stuff) 2013-10-03 20:31:29+0200 [D] Fields proposed do not match with previous language schema (Missing [u'Files description'])

it's completely broken, we can't supports multi fields language in this way

        "en": [
            {
                "hint": "Describe your Tip with a short title", 
                "key": "Short title", 
                "name": "Short title", 
                "presentation_order": 1, 
                "preview": true, 
                "required": true, 
                "type": "text", 
                "value": ""
            }, 
            {
                "hint": "Describe the details of your Tip", 
                "key": "Full description", 
                "name": "Full description", 
                "presentation_order": 2, 
                "preview": true, 
                "required": true, 
                "type": "text", 
                "value": ""
            }, 
            {
                "hint": "shit", 
                "key": "shit", 
                "name": "shit", 
                "presentation_order": 0, 
                "preview": true, 
                "required": true, 
                "type": "textarea", 
                "value": ""
            }, 
            {
                "hint": "stuff", 
                "key": "stuff", 
                "name": "stuff", 
                "options": [
                    {
                        "name": "aaaaa", 
                        "order": 0, 
                        "value": "aaaaa"
                    }, 
                    {
                        "name": "bbbbbbb", 
                        "order": 0, 
                        "value": "bbbbbbb"
                    }
                ], 
                "presentation_order": 0, 
                "preview": true, 
                "required": true, 
                "type": "radio", 
                "value": ""
            }
        ], 
        "it": [
            {
                "hint": "Describe your Tip with a short title", 
                "key": "Titolo", 
                "name": "Titolo", 
                "presentation_order": 1, 
                "preview": true, 
                "required": true, 
                "type": "text", 
                "value": ""
            }, 
            {
                "hint": "Describe the details of your Tip", 
                "key": "descrizione", 
                "name": "descrizione", 
                "presentation_order": 2, 
                "preview": true, 
                "required": true, 
                "type": "text", 
                "value": ""
            }, 
            {
                "hint": "Describe the submitted files", 
                "key": "file descriviti", 
                "name": "file descriviti", 
                "presentation_order": 3, 
                "preview": false, 
                "required": false, 
                "type": "text", 
                "value": ""
            }
        ]
    }, 

This thing need to be changed. The public API need to remain the same, so, the output from /contexts and the input of /submission MUST remain the same. but /admin/context need to change, and permit a separate handling of language and fields.

fields need to be unique, with an unique ID inside, ID is the 'key'

tranlation of 'name' and 'hint' would be addressed by the same ID, but almost we avoid this desync, that's is very difficult to handle in safety.

for obtain this, we've to:

• do not change external API, wrap in invisible way those changes
• refactor internally Context object
• develop an utility object that would help in manage these update, creation, validation, acquisitions.

[vecna]

The goal of today is refactor the internal usage of context.fields with two separate variables:

-    fields = Pickle()
+    fields = Pickle() # TO BE REMOVED
+
+    # Unique fields is a dict with a unique ID as key,
+    # and as value another dict, containing the field
+    # descriptive values:
+    # "presentation_order" : int
+    # "preview" : bool
+    # "required" : bool
+    # "type" : unicode
+    # "options" : dict (optional!)
+    unique_fields = Pickle()
+
+    # Localized fields is a dict having as keys, the same
+    # keys of unique_fields, and as value a dict, containing:
+    # 'name' : unicode
+    # 'hint' : unicode
+    localized_fields = Pickle()

[vecna]

The things are going good, but there are three elements:

• GLClient has a bug, when is deleted a field, in fact is sent again via REST
• some unitTest are failing, I've barely fixed tests/handlers/admin.py because perform get/update/create in context, other need to be aligned
• database migration between 6 to 7 is missing, would be done before merging this in master

[vecna]

Update:

• GLClient has an issue that I'm failing in solving: when a field is 'deleted', it's echoed again when context is update.
• unitTest: all UT has been aligned wirh the new fields system GlobaLeaks/GLBackend@4cd9e48
• Database since version 6 to 7 supports the new fields system GlobaLeaks/GLBackend@9a71484

Missing:

• testing with iGlobaLeaks
• testing with GLDroid
• testing with informacam

The API is not changed, so by theory, these software would not have trouble. But now fields[\'key\'] is different from fields[\'name\'] ... (before was the same) and this may expose bugs in the existing clients.

[evilaliv3]

closing this because really old.