search

globaleaks / whistleblowing-software

GlobaLeaks is free, open-source whistleblowing software enabling anyone to easily set up and maintain a secure reporting platform.
https://www.globaleaks.org
Other
1.22k stars 268 forks source link

IE-11 Base64 encoding fails for large custom CSS files #1816

Open NSkelsey opened 7 years ago

NSkelsey commented 7 years ago

This issue was identified with a custom css file of around 5MB. Much smaller stylesheets exhibited the behaivor as well.

A quick patched solution was simply to link the stylesheet as from a static path.

It is a large performance hit to do the decoding and modification in the DOM. This ticket is here to track the conversation.

NSkelsey commented 7 years ago

The issue exists in edge as well.

evilaliv3 commented 7 years ago

I've retested the issue with the problematic CSS and i'm not able to verify it.

Here follows some consideration that would not solve the issue but that probably should be addressed on the topic as well.

I would consider valuable in general to enforce limited sizes on the customizations; Given that the whole uncompressed bootstrap weight 230kb and its fonts in WOFF format weight 30k i think that the customization css should not weight more thant 100k;

the same should apply to the custom HTML and CSS.