Closed tbhallett closed 1 month ago
[heart] Mehran Hosseini reacted to your message:
From: Tim Hallett @.> Sent: Tuesday, August 20, 2024 12:55:58 PM To: globalfund-pri/model_code_pipeline @.> Cc: Mehran Hosseini @.>; Review requested @.> Subject: [globalfund-pri/model_code_pipeline] Approach C and associated graph (PR #33)
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
This introduces 'Approach C' to the Analysis class that produces portfolio projections when the all countries are funded to the same funding_fraction.
It also uses this functionality to produce another one of the set of Mehran graphs that were discussed under #30https://urldefense.com/v3/__https://github.com/globalfund-pri/model_code_pipeline/issues/30__;!!OigWWnZj_OUW47Tk4A!GgLUsZX7rZ-eglCKbVP7WoxUam3hxIOe-1Nw3--PGh0J0G6Ak5zN62gbfkDmf4d3y_NA36vEhYgNjjrQdhIMcqUXRcxJWtzoV_4$.
Other changes are commented-on in the files.
You can view, comment on, or merge this pull request online at:
https://github.com/globalfund-pri/model_code_pipeline/pull/33https://urldefense.com/v3/__https://github.com/globalfund-pri/model_code_pipeline/pull/33__;!!OigWWnZj_OUW47Tk4A!GgLUsZX7rZ-eglCKbVP7WoxUam3hxIOe-1Nw3--PGh0J0G6Ak5zN62gbfkDmf4d3y_NA36vEhYgNjjrQdhIMcqUXRcxJuXMXo8g$
Commit Summary
File Changes
Patch Links:
— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/globalfund-pri/model_code_pipeline/pull/33__;!!OigWWnZj_OUW47Tk4A!GgLUsZX7rZ-eglCKbVP7WoxUam3hxIOe-1Nw3--PGh0J0G6Ak5zN62gbfkDmf4d3y_NA36vEhYgNjjrQdhIMcqUXRcxJuXMXo8g$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AVY2K7M5L7K4CVRW6PX366TZSM4F5AVCNFSM6AAAAABMZ3FALSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3TKNJYGA4DSOA__;!!OigWWnZj_OUW47Tk4A!GgLUsZX7rZ-eglCKbVP7WoxUam3hxIOe-1Nw3--PGh0J0G6Ak5zN62gbfkDmf4d3y_NA36vEhYgNjjrQdhIMcqUXRcxJsZmPfNs$. You are receiving this because your review was requested.Message ID: @.***>
Shall we merge it?
This introduces 'Approach C' to the Analysis class that produces portfolio projections when the all countries are funded to the same
funding_fraction
.It also uses this functionality to produce another one of the set of Mehran graphs that were discussed under #30.
Other changes are commented-on in the files.