search

globalgov / manydata

The portal for global governance data
https://manydata.ch
GNU Affero General Public License v3.0
9 stars 0 forks source link

Update GitHub actions #211

Closed jhollway closed 2 years ago

jhollway commented 2 years ago

Description

These patch changes update Github actions to implement package caching.

Package

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #211 (96f4284) into main (dd9bf30) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 96f4284 differs from pull request most recent head f3f1eaa. Consider uploading reports for the commit f3f1eaa to get more accurate results

@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage   75.95%   75.95%           
=======================================
  Files           6        6           
  Lines         603      603           
=======================================
  Hits          458      458           
  Misses        145      145

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd9bf30...f3f1eaa. Read the comment docs.

henriquesposito commented 2 years ago

Since the binary checks were failing for ubuntu not finding the "extra packages" declared, I removed the any:: calls in the prchecks. I think that the newest version of GitHub actions calls any:: by default when we use "extra packages" (https://github.com/r-lib/actions/blob/v2-branch/setup-r-dependencies/action.yaml). However, I am not sure, could you please double check @jhollway and @BBieri? All the binary checks pass now. Thank you!

One more thing, there was a consistency issue between using "ubuntu-latest" calls and "ubuntu-20-04" calls across different (and within the same) action files. The issue was that whenever we change to "ubuntu-latest" the "expected status of ubuntu-20-04 was not found"... Although I tried using "ubuntu-latest" consistently across, I was not able to without removing action steps (specifically, the issue happens on line 57 of the pushrelease file). Therefore, I changed all the calls consistently across to "ubuntu-20-04". Could you also please double check this is ok? Thank you again!

jhollway commented 2 years ago

Thanks @henriquesposito, can you please update the workflow files in {manypkgs} so that these can be updated in all the other manyverse packages too?

henriquesposito commented 2 years ago

I have tried to fix the binary checks issue all day, but I am not sure what the issue is... It could be related to a new version of the openssl package having been just released yesterday (see https://cran.r-project.org/web/packages/openssl/index.html).

Also, see this: https://github.com/jeroen/openssl/issues/101

henriquesposito commented 2 years ago

I have removed the {rcmdcheck} package from the extra packages installed in the PR checks actions. Installing the package was causing the actions to fail in Windows (due to an issue with a conflict of versions of a dependency called openssl, from what I can tell). Also, I am not sure we need to install the package to run these checks nor do we call it anywhere directly in the files. All the actions pass now. @jhollway please let me know if this is ok for you or if you would like me to bring the package back and find another way around it? Thank you.

jhollway commented 2 years ago

please let me know if this is ok for you or if you would like me to bring the package back and find another way around it?

That's fine if it all works. Once it's all working correctly as it should, it would be useful to update also the workflow templates in {manypkgs}.

henriquesposito commented 2 years ago

@jhollway I finally was able to fix the issue with package caching in the PR checks file and it seems that all works now. I have also updated the workflow action files across the 'many' packages and the templates in {manypkgs}. Please let me know if there are any other issues you want me to address in this PR. Thank you.