globalgov / manydata

The portal for global governance data
https://manydata.ch
GNU Affero General Public License v3.0
9 stars 0 forks source link

Update test expectations #297

Closed teunbrand closed 8 months ago

teunbrand commented 9 months ago

Description

Context

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break manydata.

Changes in this PR

This PR updates fragile tests expectations from fixed values to values derived from ggplot2. The suggested changes should pass for current CRAN ggplot2 and the incoming update.

More information

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in https://github.com/tidyverse/ggplot2/issues/5588. We hope that this PR might help manydata get out a fix if necessary.

Checklist:

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (54c9f9c) 74.13% compared to head (bf526b1) 74.26%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #297 +/- ## ========================================== + Coverage 74.13% 74.26% +0.13% ========================================== Files 5 5 Lines 750 750 ========================================== + Hits 556 557 +1 + Misses 194 193 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

teunbrand commented 9 months ago

This is just a friendly reminder that the release of ggplot2 is scheduled soon.