search

globalgov / messydates

R package for Extended Date/Time Format (EDTF)
https://globalgov.github.io/messydates
Other
15 stars 1 forks source link

Hotfixes on GitHub workflows #53

Closed jhollway closed 2 years ago

jhollway commented 2 years ago

This PR fixes some of the issues with the GitHub workflow files. For more information of all the changes in this version, please see #50.

codecov[bot] commented 2 years ago

Codecov Report

Merging #53 (0eb1a66) into main (73e00fb) will decrease coverage by 0.08%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   91.59%   91.50%   -0.09%     
==========================================
  Files          12       11       -1     
  Lines         773      765       -8     
==========================================
- Hits          708      700       -8     
  Misses         65       65
Impacted Files Coverage Δ
R/expand.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 73e00fb...0eb1a66. Read the comment docs.

henriquesposito commented 2 years ago

@jhollway maybe we should close this PR, instead of merging it... The issues with the CI workflows were all solved a while ago, but there have also been several changes to messydates (i.e. addition of the new mreport() function). We can open a real patch PR instead. Though, since the version on CRAN is 0.3.0, we might need to manually update the version for the main branch beforehand. What do you think? Thank you.