Closed henriquesposito closed 7 months ago
Attention: Patch coverage is 84.75177%
with 43 lines
in your changes are missing coverage. Please review.
Project coverage is 88.36%. Comparing base (
8f9448f
) to head (65d2907
). Report is 11 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
R/proportional.R | 58.13% | 18 Missing :warning: |
R/logical.R | 89.47% | 8 Missing :warning: |
R/messydates-defunct.R | 0.00% | 8 Missing :warning: |
R/set.R | 63.63% | 4 Missing :warning: |
R/coerce_to_messydate.R | 96.49% | 2 Missing :warning: |
R/class.R | 94.73% | 1 Missing :warning: |
R/duration.R | 94.73% | 1 Missing :warning: |
R/operate.R | 97.95% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The way we currently handle NAs for logical operations has been causing issues with {manydata}
and other packages that depend on {messydates}
. Perhaps we need to review this feature to make sure there will be no other issues before merging this PR.
Description
This minor PR expands logical comparisons and added proportional methods for 'mdate' objects.
Functions
mdates_duration
class that introduces methods to annotate a duration or period with representations of its uncertainty<
,>
,<=
,>=
) (thanks @WerthPADOH)%l%
%le%
,%g%
,%ge%
,%><%
,%>=<%
)mdate()
foras_messydate()
%intersect%
and%union%
)is_element()
byis_subset()
for clarity and consistencymake_messydates()
function to also construct ranges of datesChecklist: