Issue with logical comparisons for certain versions of R > 4.3

globalgov / messydates

R package for Extended Date/Time Format (EDTF)

https://globalgov.github.io/messydates

Other

15 stars 1 forks source link

Issue with logical comparisons for certain versions of R > 4.3 #83

Closed henriquesposito closed 7 months ago

henriquesposito commented 7 months ago

For certain versions of R (version > 4.3), it appears that certain types of 'mdates' cannot be logically compared. For example:

as_messydate("0039") < as_messydate("1000")

henriquesposito commented 7 months ago

I have tried to address the issues while making sure this is compatible with R > 3.5, as we currently have in description file. However, this was not tested extensively and we could potentially run into issues. We could also require users to use R < 4.3 but I am not sure if this would be too restrictive for users. What do you think @jhollway and @jaeltan ? Thank you.

jhollway commented 7 months ago

R < 4.3 is not sustainable. R ≥ 4 is unfortunate but could be justifiable. If this is a strategic decision, we could discuss Friday?