Check for usage of exceptions in logging arguments

globality-corp / flake8-logging-format

Flake8 extension to validate (lack of) logging format strings

Apache License 2.0

134 stars 21 forks source link

Closed m-burst closed 5 years ago

m-burst commented 5 years ago

I've added some new violations to check:

Check that logging calls in except blocks do not incorporate exceptions into the message (logger.exception or is preferred, or exc_info=True for level other than ERROR)
Check for logger.error(..., exc_info=True) (logging.exception is preferred)
Check for redundant logger.exception(..., exc_info=True)

m-burst commented 5 years ago

Hey guys, can someone please take a look at this?

jessemyers commented 5 years ago

@m-burst Thanks for the ping. I'd missed seeing this PR. I will look later today.

m-burst commented 5 years ago

@jessemyers Please take a look at my update and comments. Thanks!

m-burst commented 5 years ago

Thanks! When can we see this released? :)

jessemyers commented 5 years ago

It already is. 0.5.0

m-burst commented 5 years ago

Thanks a lot!