add a check for "extra" arguments clashing with default LogRecord fields

globality-corp / flake8-logging-format

Flake8 extension to validate (lack of) logging format strings

Apache License 2.0

134 stars 21 forks source link

add a check for "extra" arguments clashing with default LogRecord fields #22

Closed si14 closed 3 years ago

si14 commented 4 years ago

Resolves #17

jameschung2019 commented 4 years ago

Hey there, please close this PR or merge it appropriately. It will be auto-closed in 48 hours if not acted upon.

If you decide to merge it, comment here and take ownership to coordinate, schedule, and get it done. Thanks!

si14 commented 4 years ago

Hey!

It was merging fine when I've sent the PR, I'll merge against master in a few days.

si14 commented 4 years ago

Oh sorry, I was seeing that big red cross and didn't realise what it's saying next to it. Apparently it can be clearly merged already if someone approves it.

si14 commented 3 years ago

Thanks for merging this!

By the way, is there a chance you can cut a release with this PR?