search

globality-corp / flake8-logging-format

Flake8 extension to validate (lack of) logging format strings
Apache License 2.0
134 stars 21 forks source link

Switch testing from nose to pytest #30

Closed SJLC closed 1 year ago

SJLC commented 2 years ago

Maintenance on the nose test framework stopped about 6 years ago, with devs advising users to find another framework[1]

pytest on the other hand has a thriving community, and seems like a nice modern alternative to nose.

Note that tests are no longer going to be run from 'setup.py test' per current pythonic best practices[2], but rather from tox

tox -e py36 testenv

Also note the coverage exclude rule in tox.ini includes an exclusion for api.py since that was excluded from the old nosetests report.

[1] https://nose.readthedocs.io/en/latest/#note-to-users [2] https://docs.pytest.org/en/latest/explanation/goodpractices.html#do-not-run-via-setuptools

piercefreeman commented 1 year ago

Thanks @SJLC for the PR. Had to do this as part of https://github.com/globality-corp/flake8-logging-format/pull/46, so going to close this PR.