search

globality-corp / flake8-logging-format

Flake8 extension to validate (lack of) logging format strings
Apache License 2.0
134 stars 21 forks source link

Plugin not working in latest flake8 version #35

Closed guigarfr closed 1 year ago

guigarfr commented 1 year ago

flake8 has released a couple of version in the last days (5.0.0 and 5.0.1). When running flake8, it provides this error (fails with both flake8 versions):

pip install flake8==5.0.0
flake8 .
There was a critical error during execution of Flake8:
plugin code for `flake8-logging-format[logging-format]` does not match ^[A-Z]{1,3}[0-9]{0,3}$
guigarfr commented 1 year ago

Just saw there is a PR for it (https://github.com/globality-corp/flake8-logging-format/pull/33) but there was not an open issue.

cpina commented 1 year ago

Just found the same problem - thanks for reporting it @guigarfr

christianbundy commented 1 year ago

Looks like #33 was merged (thanks!), looking forward to upgrading once this is released to pypi.

christianbundy commented 1 year ago

@tonybajan-globality Anything we can do to help get this published to pypi?

guigarfr commented 1 year ago

https://github.com/globality-corp/flake8-logging-format/issues/42

piercefreeman commented 1 year ago

Thanks for the contributions all. We've fixed the build pipeline and cut 0.7.4 to pypi, which should take care of this error. I've confirmed in another dependent repo that this issue looks fixed on flake8 5.x.x.