globalizejs / globalize

A JavaScript library for internationalization and localization that leverages the official Unicode CLDR JSON data
https://globalizejs.com
MIT License
4.8k stars 603 forks source link

Meta: update dependencies #741

Closed Mottie closed 6 years ago

Mottie commented 7 years ago

Update dependencies & added the npm auto-generated package-lock.json file.

Mottie commented 7 years ago

Hmm, it looks like the grunt-jscs update includes a bunch of rule changes... I'm seeing over 50 style errors now.

requireCapitalizedComments

Example message:

requireCapitalizedComments: Comments must start with an uppercase letter, unless it is part of a textblock at Gruntfile.js :

  201 |       ].join( "\n" ) );
  202 |
  203 |     // messageformat
------------------^

requireCapitalizedComments: Comments must start with an uppercase letter, unless it is part of a textblock at src/common/format-message.js :
3 |], function( toString ) {
4 |
5 |/**

-----^ 6 | formatMessage( message, data ) 7 |

Do you want this set option to false, or do you want to update the comments?

requireSpacesInsideParentheses

Example messages:

requireSpacesInsideParentheses: Missing space after opening round bracket at src/common/create-error.js :

    1 |define([
--------------^

requireSpacesInsideParentheses: Missing space before closing round bracket at Gruntfile.js :

  630 |    compress: {
  631 |     gz: function( fileContents ) {
  632 |      return require( "gzip-js" ).zip( fileContents, {}).length;
--------------------------------------------------------------^

I'm not sure what changes need to be made to the entry to prevent this error and not require modifying the source code.

rxaviers commented 7 years ago

Tools are pretty outdated by now, I wish we were using eslint and npm scripts instead of grunt.

Having said that, I think it's not worth to update and have to fix these jscs issues...

rxaviers commented 6 years ago

Thanks @Mottie, although 1 year later, merged - I've ignored the devDependencies bumps that break existing tools.