search

globalizejs / globalize

A JavaScript library for internationalization and localization that leverages the official Unicode CLDR JSON data
https://globalizejs.com
MIT License
4.8k stars 603 forks source link

Numbers: support compact mode (2/2) #759

Closed rxaviers closed 7 years ago

rxaviers commented 7 years ago

Updates:

rxaviers commented 7 years ago

Much thanks to @sieverk 🎉

sieverk commented 7 years ago

Nah, sorry about all the holdup on my end. Much thanks for finishing up and merging!

necolas commented 7 years ago

Please could a new version of the library including these changes be published?

paularmstrong commented 7 years ago

@rxaviers can we get a new version published with this, please?

rxaviers commented 7 years ago

@necolas and @paularmstrong, unfortuntely this feature isn't present in the examples and compiler tests ([1] and [2]). Can you help me get these updated? I can create an alpha release now to help it.

rxaviers commented 7 years ago
necolas commented 7 years ago

At the moment we are forking several globalize packages. It would be great if you could publish non-alpha versions anyway and update examples, etc., later.

rxaviers commented 7 years ago

I feel your pain by working with forks, but an actual globalize release is supposed to be stable, including complete tests and docs/examples.

diligiant commented 7 years ago

@necolas I know the feeling ;( How about I do what's needed tomorrow morning (Europe) so @rxaviers can release 1.4 tomorrow?

necolas commented 7 years ago

I feel your pain by working with forks

Twitter works with forks because it allows the team to make progress. Getting patches merged and released upstream here has been very slow so far :)

rxaviers commented 7 years ago

Getting patches merged and released upstream here has been very slow so far :)

Good old days where jQuery Foundation sponsored dedicated work for its projects, but the Foundation broke. Even working at PayPal with i18n (who uses globalize too), there's no immediate budget to work on the open source by itself. Instead it also has its forks and wrappers.

Thank you for your continued effort to bringing patches and improvements upstream for the greater good. I also believe on it and try my best to find time among the pile of growing work (and life stack) to get this moving. Unfortunately, my best response for now is that all help is appreciated.

necolas commented 7 years ago

I'm concerned to hear that PayPal has also forked these projects and isn't contributing back upstream

rxaviers commented 7 years ago

PayPal contributed back timezone support and dateToParts.