search

globalizejs / globalize

A JavaScript library for internationalization and localization that leverages the official Unicode CLDR JSON data
https://globalizejs.com
MIT License
4.8k stars 603 forks source link

LICENSE: Add MIT header #780

Closed rxaviers closed 7 years ago

rxaviers commented 7 years ago

@scottgonzalez @kborchers please can you confirm this update is ok? Thanks

kborchers commented 7 years ago

Not sure how we missed this before but the copyright line needs to be updated to

Copyright JS Foundation and other contributors, https://js.foundation

Otherwise the addition of the MIT header LGTM

rxaviers commented 7 years ago

Copyright JS Foundation and other contributors, https://js.foundation

Updated in https://github.com/rxaviers/globalize/tree/license-mit, though it seems like github hasn't synced my updates in this PR yet (weird, never saw that before)

kborchers commented 7 years ago

Wow, that is very strange 😕

rxaviers commented 7 years ago

There we go, now it's synced.

scottgonzalez commented 7 years ago

I know this was already merged, but since I was tagged, I figured I'd still leave my feedback.

I personally avoid doing this type of labeling because we've gone through the effort of informing users that even though this package itself is released under the terms of the MIT license, it has portions of its own code, as well as dependencies, that are released under different licenses. If you want to include the heading of "The MIT License (MIT)", I would suggest adding that on L14 rather than L1.

rxaviers commented 7 years ago

Makes sense Scott, I'm pushing an amend commit soon.

rxaviers commented 7 years ago

Updated in d01e049