search

globalizejs / globalize

A JavaScript library for internationalization and localization that leverages the official Unicode CLDR JSON data
https://globalizejs.com
MIT License
4.8k stars 603 forks source link

"Hello World (plain JavaScript)" demo does not work #832

Closed gingerbbm closed 6 years ago

gingerbbm commented 6 years ago

I followed the very simple instructions at https://github.com/globalizejs/globalize/tree/master/examples/plain-javascript but the Globalize zip doesn't contain the required dist folder and contents.

rxaviers commented 6 years ago

On that README.md we have:

  1. Click at Globalize releases tab.

The correct link is: https://github.com/globalizejs/globalize/releases

Would you like to update it? Thanks

gingerbbm commented 6 years ago

Tried it and it works - thanks. I would gladly update the .MD but no idea what the process is to do that. Give me a clue and I'll try.

rxaviers commented 6 years ago

Excellent. Sure, you can even use github interface to edit the file.

When naming the commit, please make sure it begins with "Docs: ".

Let me know if you have further questions. Thanks

gingerbbm commented 6 years ago

OK, it's done - I think. I did a pull request. Not sure what happens next... let me know if I did something wrong. Thanks!

rxaviers commented 6 years ago

Thank you! PR #833 is now merged.