search

globalizejs / globalize

A JavaScript library for internationalization and localization that leverages the official Unicode CLDR JSON data
https://globalizejs.com
MIT License
4.8k stars 605 forks source link

Unit: Fix formatUnit to display formatted number with compound units #839

Closed EdwardSalter closed 6 years ago

EdwardSalter commented 6 years ago

When using compound units with the formatUnit function, it now correctly displays the formatted value and instead of dumping the raw value into the message.

jsf-clabot commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Edward Salter seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

EdwardSalter commented 6 years ago

I have now signed the CLA.

EdwardSalter commented 6 years ago

Fixes #838

rxaviers commented 6 years ago

Good catch! Thanks for your fix!