Number: Added zero check for toPrecision

globalizejs / globalize

A JavaScript library for internationalization and localization that leverages the official Unicode CLDR JSON data

https://globalizejs.com

MIT License

4.8k stars 605 forks source link

Closed hmizutanitsi closed 5 years ago

hmizutanitsi commented 5 years ago

Number: Added zero check for toPrecision

"formatNumber returns NaN for 0, if max/minimumSignificantDigits is set

Fixed: #706

rxaviers commented 5 years ago

Awesome, thank you for your fix. Please, can we add a unit test to confirm it?

hmizutanitsi commented 5 years ago

No problem! I added a case to test number==0.

rxaviers commented 5 years ago

Thank you!