globalizejs / globalize

A JavaScript library for internationalization and localization that leverages the official Unicode CLDR JSON data
https://globalizejs.com
MIT License
4.8k stars 602 forks source link

Remove GPL License from upstream packages #900

Open michaelfarrell76 opened 4 years ago

michaelfarrell76 commented 4 years ago

When adding a downstream dependency strong-soap I was getting a warning because adm-zip had GPL code and this fails our license check preventing us from using this package. Since then, the GPL code has been removed but the package tree needs to be updated. I've traced this update and I believe that cldr-data is the next package that needs to be updated in this process, followed by globalize

Screen Shot 2020-06-03 at 11 48 43 AM

Proposal

raymondfeng commented 4 years ago

@michaelfarrell76 As I can tell from https://github.com/globalizejs/globalize/blob/master/package.json#L76, cldr-data-downloader is dev dependency, which won't be installed/used at runtime. Your scanning tool probably didn't understand that.

michaelfarrell76 commented 4 years ago

hmmm im pretty sure that fossa is only scanning dependencies and not devDependencies. Ive seen other most packages from regular dependencies -> devDependencies and this goes away.

this could be coming up because the downstream packages are pinned to an earlier version of globalize where cldr-data ended up as a regular dependency.

I was unable to determine why the fossa output in that image points from globalize-> cldr-data since i did not find this anywhere in the package.json. was there a recent change that potentially removed this dep?