search

globallogicuki / provider-harbor

Crossplane provider for Harbor based on terraform-provider-harbor
Apache License 2.0
2 stars 1 forks source link

Fix registryIdRef #5

Closed tschlaepfer closed 4 months ago

tschlaepfer commented 4 months ago

Description of your changes

This pull request fixes the registryIdRef for Replication object by adding a custom extractor function to fetch the "registryId" parameter of a Registry object. Additionally, this pull request adds an option to the Project resource to create cache proxy projects by supplying the registryId parameter also via registryIdRef.

Fixes #4

I have:

How has this code been tested

The provider has been tested locally as described in #4. Results from the test can also be found there.

lornest commented 4 months ago

Yeah, ignore me @tschlaepfer sorry! I deleted my comment because it was just me being stupid - I was still running my own version of the provider! Looks good to me, just a final few checks and I'll merge

lornest commented 4 months ago

Thanks for the contribution @tschlaepfer. Linting was playing up - I fixed the real lint errors (was just some go formatting), but looks like the other issue is a known issue with the golintci Github Action so I'm merging and will resolve in the main branch.