Chore: feedback cleanup - Githubissues

globalmangrovewatch / gmw-users

All functionality for user accounts in the Global Mangrove Watch platform

MIT License

2 stars 2 forks source link

Chore: feedback cleanup #334

Closed julia-rom closed 1 year ago

julia-rom commented 1 year ago

Changes based on feedback: Q2.5 Is marked as mandatory in the tool but shouldn’t be

removed required indicator

Q5.3f Percentages shouldn’t be able to total more than 100%

There is now error text that appears if percentages equal more than 100%
Setting a custom error for a fields array (instead of individual field items) with react hook form ended up being more complex than expected. For now, users can still submit answers that equal more than 100%, but a warning also displays

Q5.3g Can the table rows be orientated horizontally

set horizontal rows since there are only two row items, still mobile friendly

Q6.2b Can the species be organized as in Q5.3e (in case people plant non-native species or our species ranges are wrong)

added organizeMangroveSpeciesList to library

Q6.3 Bold typeface on question needed

fixed

Q7.5: The sum of these totals should not be greater than the value in Q7.4

warning text appears if sum of totals exceeds value in 7.4

Q7.5a: This question needs to pull the activities from both Q6.2 and Q6.4

fixed (previously it was only loading answers from 6.4)

github-actions[bot] commented 1 year ago

A review app was created for this PR. See https://gmw-users-staging-c6c35c5.herokuapp.com/

github-actions[bot] commented 1 year ago

A review app was created for this PR. See https://gmw-users-staging-5b77ee0.herokuapp.com/

github-actions[bot] commented 1 year ago

The review app https://gmw-users-staging-c6c35c5.herokuapp.com/ was deleted.

github-actions[bot] commented 1 year ago

The review app https://gmw-users-staging-5b77ee0.herokuapp.com/ was deleted.