globalpayments / node-sdk

GNU General Public License v2.0
23 stars 26 forks source link

[IMPORTANT] PCI Compliance issue in 1.4.9 #70

Open MilesTFox opened 9 months ago

MilesTFox commented 9 months ago

You need to edit node_modules/globalpayments-api/lib/src/Gateways/XmlGateway.js and comment out the contents of XmlGateway.prototype.log. This is a PCI compliance issue as it saves the entire transaction including all credit card details to disk unencrypted.

Before:

 XmlGateway.prototype.log = function (text) {
        fs.appendFile('logger.txt', text + '\n', function (err) {
            if (err)
                throw err;
        });
    };

After:

 XmlGateway.prototype.log = function (text) {
        /*
        fs.appendFile('logger.txt', text + '\n', function (err) {
            if (err)
                throw err;
        });
        */
       });
   };