globalpayments / rxp-android

Global Payments Ecommerce Android Library
MIT License
8 stars 17 forks source link

added rules to proguard file, and handle null listener, disabled logs… #23

Closed eduardo76609 closed 3 years ago

slogsdon commented 3 years ago

@eduardo76609 We will need to include the fix the params issue along with these to meet the immediate customer needs.

eduardo76609 commented 3 years ago

@eduardo76609 We will need to include the fix the params issue along with these to meet the immediate customer needs.

Hello Shane, The change of the button text cannot be solved because the button comes inside the HTML and both platforms do not have control over it, what both platforms do, both IOS and Android is to send the parameter, but the API must be in charge of receive the parameter that we send and put it in the text of the button

slogsdon commented 3 years ago

@eduardo76609 Here's a quick example of what's needed to fix this issue:

- HashMap<String, String> map = new HashMap<>();
+ HashMap<String, String> map = hppManager.getMap();

Which would occur in HPPManagerFragment.getHPPPostData. This starts map with the current data set via the HPPManager instance allowing the key-value pairs from the merchant's HPP Request Producer URL to override the data in the HPPManager instance, keeping backwards compatibility. We have 100% control over this process in both Android and iOS.

eduardo76609 commented 3 years ago

@eduardo76609 Here's a quick example of what's needed to fix this issue:

- HashMap<String, String> map = new HashMap<>();
+ HashMap<String, String> map = hppManager.getMap();

Which would occur in HPPManagerFragment.getHPPPostData. This starts map with the current data set via the HPPManager instance allowing the key-value pairs from the merchant's HPP Request Producer URL to override the data in the HPPManager instance, keeping backwards compatibility. We have 100% control over this process in both Android and iOS.

Hi Shane, you are absolutely right, I thought that sending the parameter in the first request was enough, I considered that the data of the first response was sent in the second one without adding anything else, but in this case, I understood that the parameters of the first request are joined with the response of the same and sent to the second request (postHPPData).

MicrosoftTeams-image (1)