Looks great, thanks for opening the PR! I bet this has caught out a few people. I changed the destination to development (we don't merge directly to master) and it caused a couple conflicts though, sorry!
What a pity.
That's my first time contributing code on github.
So selecting the wrong branch(master).
I will open a new PR for the branch of globalsign:development.
Thanks.
Hi @xcFelix
Looks great, thanks for opening the PR! I bet this has caught out a few people. I changed the destination to
development
(we don't merge directly to master) and it caused a couple conflicts though, sorry!Dom