search

globalsign / mgo

The MongoDB driver for Go
Other
1.97k stars 230 forks source link

Partial 4.0 transaction support #276

Closed duskglow closed 6 years ago

duskglow commented 6 years ago

(resubmitting to fix conflicts and to send to the correct branch)

This is a partial fix to #177. It supports partial 4.0 transactional support. Documentation is in the .md file in the root.

Please note that this is only partial support. The standard Remove, Update, Insert, and Upsert transaction functionality is added and fully tested, but bulk transactions are not. This is not functionality we needed at this time, but we'll be happy to work with you to get it added.

To the best of our knowledge, these changes are fully backwards compatible.

We also updated some of the infrastructure to also work with MacOS so we could do testing.

Please let us know if you have questions or concerns. We at The Home Depot are excited to assist the community in this way as much as we are able.

duskglow commented 6 years ago

This fixes the branch from the previous pull request.

There is one conflict. I'm not sure why it's a conflict, if you accept this PR, then my line is correct. I can't really resolve it. Please let me know how you want to proceed.

Again, I'm not sure why the tests are failing... they work for us.

eminano commented 6 years ago

Hi @duskglow,

Thanks for changing the target branch. However your diff seems to include lots of previous commits. Did you make sure the branch you were working on locally was forked from the last development branch?

I'm reluctant to go through with this PR without a clean commit diff, so could you please sort that out? It might explain the conflict and the failing tests.

Thanks in advance, Esther

duskglow commented 6 years ago

okay. Thinking about it, you're right. We're going to completely redo the pull request. Look for something in a day or two.