search

globalsign / mgo

The MongoDB driver for Go
Other
1.97k stars 230 forks source link

Go modules support #283

Closed jerome-laforge closed 5 years ago

jerome-laforge commented 6 years ago

Hello Could you tag with support semantic version? Could you add go.mod in order to define all dependencies?

Thx Jérôme

maitesin commented 6 years ago

Hi @jerome-laforge ,

Thanks for taking the time to write this issue. Regarding the tag version, it was changed not long ago to work better with dep, please see issue #193. What the reason why you are requesting the usage of a semantic version?

We are happy to review pull requests, so feel free to send one with the change to add the go.mod file with the dependencies.

Best regards, Oscar

jerome-laforge commented 6 years ago

Hi @maitesin,

Thanks for taking the time to write this issue. Regarding the tag version, it was changed not long ago to work better with dep, please see issue #193. What the reason why you are requesting the usage of a semantic version?

From my point of view, the semantic version is good way to manage dependency (c.f. https://github.com/golang/go/wiki/Modules#semantic-import-versioning). By the way, go modules, that will be official way to manage dependencies, requires semantic version for Version Selection(c.f. https://github.com/golang/go/wiki/Modules#version-selection)

We are happy to review pull requests, so feel free to send one with the change to add the go.mod file with the dependencies.

Ok, I will try to do that ;)

Thx for your support Best regards, Jérôme

vladbarosan commented 6 years ago

@maitesin Agree with @jerome-laforge I think everyone agrees that Semantic Version is the way to go. Also in the issue #193 you mentioned it was promised that future versions will work with dep but as of now, no new release has been made, will you make any new releases soon? Also will that release conform with semantic versioning ( e.g. v2018.11.20 wont have any breaking changes introduced in v2018.10.10) ? Also not having semantic is a big blocker for us, especially moving forward towards modules.

dsvensson commented 5 years ago

Any chance this could be released, tagged etc, any time soon? go-openapi depends on this, and one project I'm working on depends of go-openapi, and it seems like the lack of a go.mod breaks the bingo go language server.

pierrre commented 5 years ago

It seems https://github.com/go-openapi/strfmt requires mgo for the bson package only.

Maybe open an issue on https://github.com/go-openapi/strfmt and ask them to migrate to the official Go driver ? The v1.0.0 has been released recently. https://github.com/mongodb/mongo-go-driver

domodwyer commented 5 years ago

Yeah, it's probably best to move to the official driver - mgo is old code and doesn't have the development support that MongoDB is providing for their official driver!

On a related note, go.mod was merged into development several months ago so I will close this ticket.

Dom