globalsign / mgo

The MongoDB driver for Go
Other
1.97k stars 230 forks source link

Additional metrics tracking #292

Closed jacksontj closed 5 years ago

jacksontj commented 6 years ago

This adds metrics to track:

domodwyer commented 5 years ago

Hey @jacksontj

Looks good! Thanks for taking the time to open a PR however would you mind targeting the development branch? I don't imagine there's any issue as the locking is largely out of the hot paths but we typically verify performance before a release makes it to the master branch.

Thanks again for the PR, it's really appreciated!

Dom

jacksontj commented 5 years ago

@domodwyer target branch changed. I had to rebase a bit, but the commits cherry-pick in just fine :)

domodwyer commented 5 years ago

Looks great, thanks @jacksontj - really appreciate the PR

Dom

jacksontj commented 5 years ago

@domodwyer It seems that I am not authorized to merge this PR. I'm not sure if thats because I don't have write permissions, or because one of the CI jobs seems to be stuck (hasn't completed in the days since I pushed).

eminano commented 5 years ago

Hi @jacksontj,

You can't merge the PR because you don't have write permissions :)

The current build is quite broken (GitHub payload is missing a merge commit). Could you try to push to trigger the build again?

Thanks and sorry for the inconvenience! Esther

jacksontj commented 5 years ago

@eminano I fetched but there are no new commits to put in, should I close and re-open the PR instead? (I'm not sure how to re-trigger your build, I usually hit the travis UI and click the "restart build" for my projects).

domodwyer commented 5 years ago

Hi @jacksontj

Normally we would re-run the build, but in this case travis didn't pick up the branch at all. It's probably best to reopen as you suggest, sorry!

Thanks again!

jacksontj commented 5 years ago

PR closed and re-opened :)

jacksontj commented 5 years ago

There we go, travis ran and passed :tada:

eminano commented 5 years ago

Thanks a lot for your contribution @jacksontj!