globalvoices / NewsFrames-Code

Code for the NewsFrames Platform available at newsframes.org
https://newsframes.globalvoices.org
Other
2 stars 1 forks source link

Cannot add MC image to pad when the tool section is widest #11

Closed connieimdialog closed 6 years ago

connieimdialog commented 6 years ago

Hi, for example, in this project: http://gv-stage.dev.colab.coop/projects/32

if you expand the tool panel all the way out like the screenshot, doesn't seem as if you can add to pad.

screen shot 2018-05-08 at 9 26 27 am

is this just me?

shrutimehta13 commented 6 years ago

Yes cannot add to Pad when sidebar is fully expanded. also, Image cloud appears with ellipses when toggled to half. When expanded to full, the word cloud appears with more text and does not work.

sapraaman commented 6 years ago

I will try, but I don't think this is doable. Because when the sidebar is fully expanded, the frame is not even visible, and thus cannot receive messages. But I will check once.

connieimdialog commented 6 years ago

if #12 is possible then we don't need this one as critically

sapraaman commented 6 years ago

Pull request submitted for review @scttnlsn

sapraaman commented 6 years ago

This has been fixed now

shrutimehta13 commented 6 years ago

Add to pad works with all sizes of the Tool sidebar. But MC word image size varies. for e.g., image added with widest toolbar is not readable. @connieimdialog @CrisNelson Pl refer to screenshot. Is this acceptable?

screen shot 2018-05-15 at 11 34 11 am

@sapraaman can we apply height 25%,50%,100% depending on how image was added so that all look same, like Below?

screen shot 2018-05-15 at 11 53 53 am
connieimdialog commented 6 years ago

looks good on my end!