First PR for styling OMW

globalwordnet / OMW

The Open Multilingual Wordnet

http://compling.hss.ntu.edu.sg/omw/

MIT License

57 stars 9 forks source link

First PR for styling OMW #106

Closed Rohitesh-Kumar-Jain closed 3 years ago

Rohitesh-Kumar-Jain commented 3 years ago

Hi In this PR I have:

Added a verticle menu on the help page.
Added a responsive back to the top button which stays with the user as one scroll down.
Made Images responsive
Styled the contents box in the OMW.
Some small CSS changes such as changing the color of the main nav-bar.

Screenshot_2020-11-27 OMW Screenshot_2020-11-27 OMW(1) Screenshot_2020-11-27 OMW(2) Screenshot_2020-11-27 OMW(3) Screenshot_2020-11-27 OMW(4) Screenshot_2020-11-27 OMW(5)

I have kept in mind that styling should be as responsive as possible.

Rohitesh-Kumar-Jain commented 3 years ago

Hi, There is room for a lot of improvements in the frontend. Post-GSoD I would like to continue working on the frontend (will try to work on the backend as well). I think the styling needs the usage of some Javascript and it's libraries.

fcbond commented 3 years ago

Hi,

it would be great if you can stay and work on the front and back ends.

For the new styling, I like it. Can you make the title bar stay even when we scroll up?

And the help menu is not going on the left for me. Screenshot from 2020-12-01 11-14-47

Rohitesh-Kumar-Jain commented 3 years ago

Hi,

By title bar do you mean the search bar?

Is the help menu supposed to come like this?

fcbond commented 3 years ago

I did mean the search bar.

I would prefer the left menu to stay underneath the search bar as well.

On Tue, Dec 1, 2020 at 12:48 PM Rohitesh Kumar Jain < notifications@github.com> wrote:

Hi,

By title bar do you mean the search bar?

Is the help menu supposed to come like this?

[image: Screenshot 2020-12-01 at 10 04 06 AM] https://user-images.githubusercontent.com/62026125/100697791-f0197300-33bc-11eb-8aca-aaa8ccd901fb.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/globalwordnet/OMW/pull/106#issuecomment-736212447, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIPZRX2I5LFHSFNWPOLUODSSRXMBANCNFSM4UE3OW7A .

-- Francis Bond http://www3.ntu.edu.sg/home/fcbond/ Division of Linguistics and Multilingual Studies Nanyang Technological University

Rohitesh-Kumar-Jain commented 3 years ago

Hi, team, I have shifted the content bar to the right, and I think if we have a scrolling content section then we don't need back to the top button. The only disadvantage with the new styling I guess, it doesn't look good on mobiles. But I think mostly our users will be using a PC.

Should we stick to the new style?

I am attaching a link to my screen recording.

https://drive.google.com/file/d/1pbMWnRrgnPqemq9Yux4qPjZUlQsday7b/view?usp=sharing

Rohitesh-Kumar-Jain commented 3 years ago

Hi, I have made enhancements as per the meeting.

Search stays on scrolling.
Contents bar is on the right and stays on scrolling.
On clicking the Help bar, the main navigation comes and it also stays on scrolling, It is on the left side.
As we have fixed bars, I have removed back to the top buttons.
Separate theming for OMW and CILI is done.
Interface documentation and help are now 2 different things.

I have not removed the vertical menu from the interface page, because I feel that I can make it look more elegant in the next PR :sweat_smile:

Thanks & Regards. Rohitesh Jain

fcbond commented 3 years ago

This looks great, thanks.

fcbond commented 3 years ago

Sorry, I forgot to confirm the merge.

Rohitesh-Kumar-Jain commented 3 years ago

No worries : )