Closed Rohitesh-Kumar-Jain closed 3 years ago
G'day,
sorry for the long pause, I needed to think about this a little. I am afraid I was a little unclear about what I wanted --- I was expecting you to document our local validator, not John's. But on reflection I think it is useful to have documented and your documentation is very clear. Can I ask for a couple of small changes:
(i) link it from the interface documentation page doc/if.html
.
In general all documentation should be linked from either doc/if
or doc/wn
.
Note in the link that it is an external tool.
(ii) As the validation is only a subset of what we do, I think it is more useful to highlight that it is a converter, so: change the name to converter; show the doc in order converter then validator; and note that when you upload to OMW it will also be validated.
Looking forward to your documentation of the OMW validation!
Hi, Yes, I have documented our local validator along with John's, documentation for our local validator is also completed, I just need to make an Index and add some links to it. I will implement the changes required in John's converter in the next PR.
Great, looking forward to it.
On Tue, Sep 29, 2020 at 12:25 PM Rohitesh Kumar Jain < notifications@github.com> wrote:
Hi, Yes, I have documented our local validator along with John's, documentation for our local validator is also completed, I just need to make an Index and add some links to it. I will implement the changes required in John's converter in the next PR.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/globalwordnet/OMW/pull/95#issuecomment-700415460, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIPZRV5GF3KXNRCR3MTFDLSIFNMXANCNFSM4RKY7OGQ .
-- Francis Bond http://www3.ntu.edu.sg/home/fcbond/ Division of Linguistics and Multilingual Studies Nanyang Technological University
Hi, Sorry, it took me longer than usual to commit. I had actually changed the same file from the web and interface so I had some merge conflicts, then I did some wrong things and things became more complicated for me. Thanks for being patient, any suggestions and feedback is welcomed.
My 12-year-old mac is configured as Kunu, I was not able to figure out how to resolve conflicts so I created a new local copy and copy-pasted that from a backup repository that I created.
There must be a better way to resolve conflicts like this, I won't use this method in the future to resolve conflicts.
Actually, sometimes making a new one and moving things to there is the simplest way :-).
On Wed, Sep 30, 2020 at 5:15 PM Rohitesh Kumar Jain < notifications@github.com> wrote:
My 12-year-old mac is configured as Kunu, I was not able to figure out how to resolve conflicts so I created a new local copy and copy-pasted that from a backup repository that I created.
There must be a better way to resolve conflicts like this, I won't use this method in the future to resolve conflicts.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/globalwordnet/OMW/pull/95#issuecomment-701268720, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIPZRT4XKUZHFS4OK2U7GDSILZLTANCNFSM4RKY7OGQ .
-- Francis Bond http://www3.ntu.edu.sg/home/fcbond/ Division of Linguistics and Multilingual Studies Nanyang Technological University