globalwordnet / english-wordnet

The Open English WordNet
https://en-word.net/
Other
475 stars 57 forks source link

Self-loops in senses oewn-unicycle__1.06.00.. and oewn-abruptly__4.02.01.. #767

Closed goodmami closed 2 years ago

goodmami commented 3 years ago

Existing relation

In the 2021 pre-release, two senses have self-loops. Here are the relevant fragments from the XML file:

Proposed change

For oewn-unicycle__1.06.00.., it's not clear if there is some intended other sense that should be the target of the derivation, so it should probably be deleted.

For oewn-abruptly__4.02.01.., the intended target is most likely oewn-abrupt__5.00.00.sudden.00

Motivation

The testing scripts already check for loops in hypernyms and a few domain relations, but self-loops are bad no matter what relation it is.

ekaf commented 3 years ago

Yes @goodmami:

For oewn-abruptly4.02.01.., the intended target is most likely oewn-abrupt5.00.00.sudden.00

This target is confirmed by PWN 3.1, where the pertainym link indeed goes to abrupt.

And the derivation loop for unicycle already already existed in PWN 3.1 (and even 3.0), without any likely alternative, so it seems appropriate to simply delete it.

Fortunately, checking all relations shows that there are no other self-loops than these. But considering that the problem has existed at least since PWN 3.0 without being noticed, it is certainly worthwile to check all relations for self-loops.