globalwordnet / gwadoc

documentation for things like relations and parts of speech used by wordnets
https://globalwordnet.github.io/gwadoc/
Creative Commons Attribution 4.0 International
12 stars 6 forks source link

Update Co-role groups and the last three #53

Closed yoyo-go closed 4 years ago

yoyo-go commented 4 years ago

Co Role

Participle Pertainym Derivation

fcbond commented 4 years ago

Hi,

can you try and find examples were both words are in Princeton wordnet? For example 'bread knife' instead of 'ice saw', 'pastry cook' instead of 'novel writer', ... Also, 'guitar player' is in wordnet but has not been linked.

Then I think it will be good to go.

yoyo-go commented 4 years ago

Hi,

can you try and find examples were both words are in Princeton wordnet? For example 'bread knife' instead of 'ice saw', 'pastry cook' instead of 'novel writer', ... Also, 'guitar player' is in wordnet but has not been linked.

Then I think it will be good to go.

But I cannot find guitar player in Princeton wordnet, it only returns guitarist... do you mean to link guitar player with guitarist? image

fcbond commented 4 years ago

It says "your query returned result". So you did find a synset, which has two words associated with it: 'guitarist' and 'guitar player'. We choose the most-frequent, shortest, unique name as the label so we call the concept "guitarist", but it includes both 'guitarist' and 'guitar player'. So please use it.

On Sat, Oct 31, 2020 at 3:34 PM yoyo-go notifications@github.com wrote:

Hi,

can you try and find examples were both words are in Princeton wordnet? For example 'bread knife' instead of 'ice saw', 'pastry cook' instead of 'novel writer', ... Also, 'guitar player' is in wordnet but has not been linked.

Then I think it will be good to go.

But I cannot find guitar player in Princeton wordnet, it only returns guitarist... do you mena to link guitar player with guitarist? [image: image] https://user-images.githubusercontent.com/56577574/97773790-bec74080-1b8d-11eb-93a0-f46f40fc7d12.png

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/globalwordnet/gwadoc/pull/53#issuecomment-719897355, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIPZRRKV7XTLACHBJXNDP3SNO4GTANCNFSM4S4WMSHA .

-- Francis Bond http://www3.ntu.edu.sg/home/fcbond/ Division of Linguistics and Multilingual Studies Nanyang Technological University

yoyo-go commented 4 years ago

Got it! Example links are added now.

Seems like the branch has conflicts again, do I need to make a new PR just like last time did?

It says "your query returned result". So you did find a synset, which has two words associated with it: 'guitarist' and 'guitar player'. We choose the most-frequent, shortest, unique name as the label so we call the concept "guitarist", but it includes both 'guitarist' and 'guitar player'. So please use it. On Sat, Oct 31, 2020 at 3:34 PM yoyo-go @.***> wrote: Hi, can you try and find examples were both words are in Princeton wordnet? For example 'bread knife' instead of 'ice saw', 'pastry cook' instead of 'novel writer', ... Also, 'guitar player' is in wordnet but has not been linked. Then I think it will be good to go. But I cannot find guitar player in Princeton wordnet, it only returns guitarist... do you mena to link guitar player with guitarist? [image: image] https://user-images.githubusercontent.com/56577574/97773790-bec74080-1b8d-11eb-93a0-f46f40fc7d12.png — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#53 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIPZRRKV7XTLACHBJXNDP3SNO4GTANCNFSM4S4WMSHA . -- Francis Bond http://www3.ntu.edu.sg/home/fcbond/ Division of Linguistics and Multilingual Studies Nanyang Technological University

fcbond commented 4 years ago

There are a few additions I want to make, so I will not close the issue yet.