search

globalwordnet / gwadoc

documentation for things like relations and parts of speech used by wordnets
https://globalwordnet.github.io/gwadoc/
Creative Commons Attribution 4.0 International
12 stars 6 forks source link

Improve the definitions #79

Open jmccrae opened 5 months ago

jmccrae commented 5 months ago

The goal of this PR is to improve the consistency of the simple English definitions

jmccrae commented 5 months ago

Thanks for the comments.

I cleaned up the quoting strategy

I am not sure about the "words" vs "concepts" idea. It was not used consistently before and for example the longer definition of "antonym" talks about "concepts" so I think the change to "concepts" makes everything more consistent.

goodmami commented 5 months ago

@jmccrae Thanks, it now looks good to me, but I'd like to give Francis a chance to comment on the last point. @fcbond, do you recall if there was anything intentional behind "words" vs "concepts" in the definitions?

fcbond commented 5 months ago

Hi,

I'm on a train right now with limited access to email, please wait a day or two. As far as I recall, we were trying to make a difference between the definitions for synset and sense links (with the difficulty that some link types, like antonym) are used for both.

I'll comment more when I am back and have had a chance to read things properly.

On Tue, 18 Jun 2024 at 18:41, Michael Wayne Goodman < @.***> wrote:

@jmccrae https://github.com/jmccrae Thanks, it now looks good to me, but I'd like to give Francis a chance to comment on the last point. @fcbond https://github.com/fcbond, do you recall if there was anything intentional behind "words" vs "concepts" in the definitions?

— Reply to this email directly, view it on GitHub https://github.com/globalwordnet/gwadoc/pull/79#issuecomment-2176536286, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIPZRSEWLWQEDRQNXAOVO3ZIBPLVAVCNFSM6AAAAABJN3ND6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZWGUZTMMRYGY . You are receiving this because you were mentioned.Message ID: @.***>

-- Francis Bond https://fcbond.github.io/

goodmami commented 4 months ago

@fcbond Hoping things have calmed down a bit after the summit and conference. Have you had a chance to look at these changes?