search

globalwordnet / schemas

WordNet-LMF formats
https://globalwordnet.github.io/schemas/
19 stars 11 forks source link

Improve representation of sense subcategorizations #29

Closed jmccrae closed 3 years ago

jmccrae commented 3 years ago

Fix #8

goodmami commented 3 years ago

Some things:

  1. The example in index.md has an id attribute on <SyntacticBehaviour> which is not defined in the DTD
  2. <SyntacticBehaviour> still has a senses attribute even though <Sense> now has subcat. This is redundant.

I think the above are just oversights in the PR, but in #8 I also raised a couple questions that may generate some discussion.

goodmami commented 3 years ago

@jmccrae did you see my 2 points in a comment above? The latest commit hasn't added id to <SyntacticBehaviour> nor removed senses from it.

jmccrae commented 3 years ago

Sorry, just getting to thing.

On 1. I have updated the PR... it seems that this is an oversight Yes, you are probably right on 2. but I also don't want to break backwards compatibility on a minor version. As with other changes, we could note that this is deprecated and change it later in v2.0