search

globe-and-citizen / cnc-portal

The Crypto Native Portal, an app that creates a mechanism to financially acknowledge the micro contributions of Open Source collaborators along with tools that promote effective governance.
3 stars 1 forks source link

feat: implement notifications pagination for frontend #212

Closed dasarathg68 closed 4 months ago

dasarathg68 commented 4 months ago

Description

Fixes #211 Solution:

Video Demo: https://github.com/globe-and-citizen/cnc-portal/assets/31665486/1390c2ea-6d28-47e7-a38b-7417dcad6f1a

Type of change

Please delete options that are not relevant.

Checklist:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 63.63636% with 12 lines in your changes missing coverage. Please review.

Project coverage is 27.41%. Comparing base (d8939bd) to head (7e1803b). Report is 10 commits behind head on develop.

Files Patch % Lines
app/src/components/NotificationDropdown.vue 65.62% 11 Missing :warning:
app/src/views/TeamView.vue 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #212 +/- ## =========================================== + Coverage 27.11% 27.41% +0.30% =========================================== Files 71 73 +2 Lines 1184 1211 +27 Branches 267 272 +5 =========================================== + Hits 321 332 +11 - Misses 747 762 +15 - Partials 116 117 +1 ``` | [Flag](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/212/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | Coverage Δ | | |---|---|---| | [app-unit-tests](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/212/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | `27.41% <63.63%> (+0.30%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dasarathg68 commented 4 months ago

@hermannleboss moved the notifications to a separate component. Please check