search

globe-and-citizen / cnc-portal

The Crypto Native Portal, an app that creates a mechanism to financially acknowledge the micro contributions of Open Source collaborators along with tools that promote effective governance.
3 stars 0 forks source link

Feat/governance frontend v1 #237

Closed dasarathg68 closed 1 month ago

dasarathg68 commented 1 month ago

Description

This PR implements a basic UI for voting, creating proposals (directives or elections) https://www.loom.com/share/4c21e060b3d242e49ef7fc408dd40a62?sid=ddebcc24-ffaf-4a2a-ab32-81d593bbcb5e

Type of change

Checklist:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 89.79592% with 5 lines in your changes missing coverage. Please review.

Project coverage is 30.72%. Comparing base (5b522df) to head (bf97e3c). Report is 1 commits behind head on develop.

Files Patch % Lines
app/src/views/SingleTeamView.vue 0.00% 3 Missing :warning:
app/src/components/ProposalDashboard.vue 92.30% 1 Missing :warning:
app/src/components/forms/CreateProposalForm.vue 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #237 +/- ## =========================================== - Coverage 31.26% 30.72% -0.54% =========================================== Files 92 78 -14 Lines 1673 1279 -394 Branches 367 288 -79 =========================================== - Hits 523 393 -130 + Misses 986 767 -219 + Partials 164 119 -45 ``` | [Flag](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/237/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | Coverage Δ | | |---|---|---| | [api-unit-tests](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | `?` | | | [app-unit-tests](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | `30.72% <89.79%> (+2.90%)` | :arrow_up: | | [contract-unit-tests](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

farrellh1 commented 1 month ago

i think we need to add like separation between past proposal and on going proposal? @dasarathg68

dasarathg68 commented 1 month ago

i think we need to add like separation between past proposal and on going proposal? @dasarathg68

i think we need to add like separation between past proposal and on going proposal? @dasarathg68

Yes. Thanks for the input. Noted.