search

globe-and-citizen / cnc-portal

The Crypto Native Portal, an app that creates a mechanism to financially acknowledge the micro contributions of Open Source collaborators along with tools that promote effective governance.
3 stars 0 forks source link

test: add test for multi-send transfer failure #238

Open aliassan opened 1 month ago

aliassan commented 1 month ago

Description

Adds a test for multi-send transfer failure when using transfer method.

Type of change

Please delete options that are not relevant.

Checklist:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.66%. Comparing base (8d22024) to head (dd6cfb9). Report is 57 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #238 +/- ## ============================================ + Coverage 30.25% 86.66% +56.41% ============================================ Files 78 3 -75 Lines 1299 75 -1224 Branches 294 31 -263 ============================================ - Hits 393 65 -328 + Misses 784 10 -774 + Partials 122 0 -122 ``` | [Flag](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/238/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | Coverage Δ | | |---|---|---| | [app-unit-tests](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/238/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | `?` | | | [contract-unit-tests](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/238/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | `86.66% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hermannleboss commented 1 month ago

@aliassan look at this article https://shishirsingh66g.medium.com/solidity-part-4-transfer-send-reverse-5baf650acdc1

Transfer is consider less safe.

image