search

globe-and-citizen / cnc-portal

The Crypto Native Portal, an app that creates a mechanism to financially acknowledge the micro contributions of Open Source collaborators along with tools that promote effective governance.
3 stars 0 forks source link

feature/governance-main-v0.1 #239

Closed dasarathg68 closed 1 month ago

dasarathg68 commented 1 month ago

Description

image

Explanation : https://www.loom.com/share/8ae2e8219c8d4074bc7e9e4095fa9b35?sid=a40b1e99-e638-4ea6-8f7e-081bb24461be Fixes # (issue)

Type of change

Checklist:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 46.75676% with 197 lines in your changes missing coverage. Please review.

Project coverage is 41.11%. Comparing base (46c1842) to head (7d858e4). Report is 4 commits behind head on develop.

Files Patch % Lines
app/src/composables/voting.ts 0.00% 73 Missing and 1 partial :warning:
app/src/services/votingService.ts 0.00% 43 Missing and 1 partial :warning:
app/src/components/ProposalCard.vue 53.84% 16 Missing and 8 partials :warning:
app/src/components/ProposalDashboard.vue 46.66% 18 Missing and 6 partials :warning:
app/src/components/forms/CreateProposalForm.vue 42.10% 16 Missing and 6 partials :warning:
contract/contracts/Voting/Voting.sol 91.42% 6 Missing :warning:
app/src/components/forms/VoteForm.vue 93.93% 2 Missing :warning:
backend/src/controllers/teamController.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #239 +/- ## =========================================== + Coverage 36.84% 41.11% +4.26% =========================================== Files 70 93 +23 Lines 1414 2206 +792 Branches 327 498 +171 =========================================== + Hits 521 907 +386 - Misses 772 1119 +347 - Partials 121 180 +59 ``` | [Flag](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | Coverage Δ | | |---|---|---| | [api-unit-tests](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | `31.50% <0.00%> (?)` | | | [app-unit-tests](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | `39.09% <36.45%> (+2.24%)` | :arrow_up: | | [contract-unit-tests](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | `88.96% <91.42%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stravid87 commented 1 month ago

Nice work. I particularly liked the Loom video and the flow chart. My general feedback is, for the contract, storing so much information on chain makes me nervous as a potential scaling issue when then time comes to have thousands and then hopefully millions of users. For this first iteration of the CNC, I do not think memory optimization is our critical task therefore I'm not providing any specific suggestion. However, in the future, I suspect there are very clever way to store veracity of data, per say, rather than the data itself through such things as hashes, Merkle trees, etc.

Looking forward to seeing your backend hooked up to your UI/frontend!

dasarathg68 commented 1 month ago

Nice work. I particularly liked the Loom video and the flow chart. My general feedback is, for the contract, storing so much information on chain makes me nervous as a potential scaling issue when then time comes to have thousands and then hopefully millions of users. For this first iteration of the CNC, I do not think memory optimization is our critical task therefore I'm not providing any specific suggestion. However, in the future, I suspect there are very clever way to store veracity of data, per say, rather than the data itself through such things as hashes, Merkle trees, etc.

Looking forward to seeing your backend hooked up to your UI/frontend!

Thanks for the feedback, I have been searching for better ways to store the data but I did checkout a few instructors explaining big projects on YT, and they all said one thing: "Move logic offchain, store data onchain" so that it is effectively decentralized.

hermannleboss commented 1 month ago

@dasarathg68 i won't merge this into develop. Let's follow the new branch structure and rules for PR