Closed dasarathg68 closed 1 month ago
Attention: Patch coverage is 46.75676%
with 197 lines
in your changes missing coverage. Please review.
Project coverage is 41.11%. Comparing base (
46c1842
) to head (7d858e4
). Report is 4 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Nice work. I particularly liked the Loom video and the flow chart. My general feedback is, for the contract, storing so much information on chain makes me nervous as a potential scaling issue when then time comes to have thousands and then hopefully millions of users. For this first iteration of the CNC, I do not think memory optimization is our critical task therefore I'm not providing any specific suggestion. However, in the future, I suspect there are very clever way to store veracity of data, per say, rather than the data itself through such things as hashes, Merkle trees, etc.
Looking forward to seeing your backend hooked up to your UI/frontend!
Nice work. I particularly liked the Loom video and the flow chart. My general feedback is, for the contract, storing so much information on chain makes me nervous as a potential scaling issue when then time comes to have thousands and then hopefully millions of users. For this first iteration of the CNC, I do not think memory optimization is our critical task therefore I'm not providing any specific suggestion. However, in the future, I suspect there are very clever way to store veracity of data, per say, rather than the data itself through such things as hashes, Merkle trees, etc.
Looking forward to seeing your backend hooked up to your UI/frontend!
Thanks for the feedback, I have been searching for better ways to store the data but I did checkout a few instructors explaining big projects on YT, and they all said one thing: "Move logic offchain, store data onchain" so that it is effectively decentralized.
@dasarathg68 i won't merge this into develop. Let's follow the new branch structure and rules for PR
Description
Explanation : https://www.loom.com/share/8ae2e8219c8d4074bc7e9e4095fa9b35?sid=a40b1e99-e638-4ea6-8f7e-081bb24461be Fixes # (issue)
Type of change
Checklist: