globe-and-citizen / cnc-portal

The Crypto Native Portal, an app that creates a mechanism to financially acknowledge the micro contributions of Open Source collaborators along with tools that promote effective governance.
3 stars 0 forks source link

fix: update-auth-token-value #262

Closed aliassan closed 3 weeks ago

aliassan commented 1 month ago

Description

Make sure authToken value updates.

Fixes #261

Type of change

Checklist:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.81%. Comparing base (46c1842) to head (becb57c). Report is 4 commits behind head on develop.

Files Patch % Lines
app/src/services/authService.ts 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #262 +/- ## =========================================== - Coverage 36.84% 36.81% -0.03% =========================================== Files 70 70 Lines 1414 1415 +1 Branches 327 327 =========================================== Hits 521 521 - Misses 772 773 +1 Partials 121 121 ``` | [Flag](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/262/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | Coverage Δ | | |---|---|---| | [app-unit-tests](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/262/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | `36.81% <0.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hermannleboss commented 1 month ago

@aliassan i don't get why you are making this fix.

Can you explain what is the issue and what the fix is giving as solution ?

aliassan commented 1 month ago

@aliassan i don't get why you are making this fix.

Can you explain what is the issue and what the fix is giving as solution ?

Hi, I explained in issue #261 as well as the steps to reproduce.