search

globe-and-citizen / cnc-portal

The Crypto Native Portal, an app that creates a mechanism to financially acknowledge the micro contributions of Open Source collaborators along with tools that promote effective governance.
3 stars 1 forks source link

chore: add validation if env not valid and not defined #306

Closed farrellh1 closed 2 months ago

farrellh1 commented 2 months ago

Description

Add env validation in .app

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Checklist:

farrellh1 commented 2 months ago

let me know if there are env that are missing @hermannleboss , @dasarathg68 , @aliassan

farrellh1 commented 2 months ago

should i skip .env check in CI/CD @hermannleboss?

hermannleboss commented 2 months ago

should i skip .env check in CI/CD @hermannleboss?

Yes i think.

We have somes value in .env.developement

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.86%. Comparing base (fec1b15) to head (87bfa2f). Report is 25 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #306 +/- ## ============================================ + Coverage 31.50% 63.86% +32.35% ============================================ Files 16 76 +60 Lines 365 1890 +1525 Branches 72 429 +357 ============================================ + Hits 115 1207 +1092 - Misses 207 562 +355 - Partials 43 121 +78 ``` | [Flag](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/306/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | Coverage Δ | | |---|---|---| | [api-unit-tests](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/306/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | `?` | | | [app-unit-tests](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/306/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | `63.86% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hermannleboss commented 2 months ago

@farrellh1 can you add a validation to be sure that, for example if the bank implementation address is really the bank implementation address.