search

globe-and-citizen / cnc-portal

The Crypto Native Portal, an app that creates a mechanism to financially acknowledge the micro contributions of Open Source collaborators along with tools that promote effective governance.
3 stars 1 forks source link

feat: add bank management #324

Closed farrellh1 closed 1 month ago

farrellh1 commented 2 months ago

Description

Add bank management feature

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Checklist:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 85.58140% with 31 lines in your changes missing coverage. Please review.

Project coverage is 66.17%. Comparing base (d167976) to head (51e8a17). Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
...ponents/sections/SingleTeamView/BankManagement.vue 70.27% 15 Missing and 7 partials :warning:
...components/sections/SingleTeamView/BankSection.vue 76.92% 4 Missing and 5 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #324 +/- ## =========================================== + Coverage 64.53% 66.17% +1.64% =========================================== Files 101 103 +2 Lines 2670 2847 +177 Branches 582 615 +33 =========================================== + Hits 1723 1884 +161 - Misses 772 783 +11 - Partials 175 180 +5 ``` | [Flag](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/324/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | Coverage Δ | | |---|---|---| | [app-unit-tests](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | `67.57% <85.58%> (+2.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dasarathg68 commented 1 month ago

In every PR let's try to improve typing, add @typescript-eslint/no-explicit-any to your lint configuration temporarily and try to resolve some of them so that we can enforce @typescript-eslint/no-explicit-any in our pipeline soon. There are around 100 instances of "explicit any" so 5-10 per PR if possible would work I guess. (Just a suggestion, let me know what you think)

325