search

globe-and-citizen / cnc-portal

The Crypto Native Portal, an app that creates a mechanism to financially acknowledge the micro contributions of Open Source collaborators along with tools that promote effective governance.
3 stars 1 forks source link

Feat/code ql no any #337

Closed dasarathg68 closed 1 month ago

dasarathg68 commented 1 month ago

Description

Fixes #325

Type of change

Please delete options that are not relevant.

Checklist:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 55.26316% with 51 lines in your changes missing coverage. Please review.

Project coverage is 64.53%. Comparing base (8c8ea2a) to head (d167976). Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
...components/sections/SingleTeamView/BankSection.vue 11.11% 5 Missing and 3 partials :warning:
app/src/composables/tips.ts 27.27% 8 Missing :warning:
...onents/sections/SingleTeamView/ProposalSection.vue 0.00% 6 Missing :warning:
app/src/services/tipsService.ts 14.28% 6 Missing :warning:
app/src/adapters/web3LibraryAdapter.ts 0.00% 5 Missing :warning:
app/src/utils/errorUtil.ts 0.00% 4 Missing and 1 partial :warning:
...mponents/sections/SingleTeamView/MemberSection.vue 0.00% 3 Missing and 1 partial :warning:
app/src/utils/generalUtil.ts 50.00% 2 Missing :warning:
app/src/utils/web3Util.ts 0.00% 1 Missing and 1 partial :warning:
app/src/App.vue 66.66% 0 Missing and 1 partial :warning:
... and 4 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #337 +/- ## =========================================== - Coverage 64.62% 64.53% -0.09% =========================================== Files 102 101 -1 Lines 2688 2670 -18 Branches 631 582 -49 =========================================== - Hits 1737 1723 -14 + Misses 779 772 -7 - Partials 172 175 +3 ``` | [Flag](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/337/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | Coverage Δ | | |---|---|---| | [app-unit-tests](https://app.codecov.io/gh/globe-and-citizen/cnc-portal/pull/337/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen) | `65.52% <55.26%> (+0.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=globe-and-citizen#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dasarathg68 commented 1 month ago

@hermannleboss do you have something to add to this? Or can I merge?