Integration of a Linter

[stravid87]

I have noticed such changes being committed:

func (r *Repository) IsBackendURIExists(backendURL string) (bool, error) {
    var count int64
    if err := r.connection.Model(&models.Client{}).Where("backend_uri = ?", backendURL).Count(&count).Error; err != nil {
        return false, err
    }
    return count > 0, nil
}

vs

func (r *Repository) IsBackendURIExists(backendURL string) (bool, error) {
    var count int64
    if err := r.connection.Model(&models.Client{}).Where("backend_uri = ?", backendURL).Count(&count).Error; err != nil {
        return false, err
    }
    return count > 0, nil
}

Golangci-lint would be my suggestion.

How to Install

How to install using a chain of trust: NPM => chocolatey => golangci-lint

Short List of Suggested Linters

• nilerr: Finds the code that returns nil even if it checks that the error is not nil. [fast: false, auto-fix: false]
• nilnil: Checks that there is no simultaneous return of nil error and an invalid value. [fast: false, auto-fix: false]
• musttag: enforce field tags in (un)marshaled structs [fast: false, auto-fix: false]
• interfacebloat: A linter that checks the number of methods inside an interface. [fast: true, auto-fix: false]
• gosec: Inspects source code for security problems [fast: false, auto-fix: false]
• godot: Check if comments end in a period [fast: true, auto-fix: true]
• godox: Tool for detection of FIXME, TODO and other comment keywords [fast: true, auto-fix: false]
• gocognit: Computes and checks the cognitive complexity of functions [fast: true, auto-fix: false]
• gochecknoglobals: Check that no global variables exist. [fast: false, auto-fix: false]
• errchkjson: Checks types passed to the json encoding functions. Reports unsupported types and reports occations, where the check for the returned error can be omitted. [fast: false, auto-fix: false]
• copyloopvar: copyloopvar is a linter detects places where loop variables are copied [fast: true, auto-fix: false]
• bodyclose: checks whether HTTP response body is closed successfully [fast: false, auto-fix: false]
• goconst: Finds repeated strings that could be replaced by a constant [fast: true, auto-fix: false]
• noctx: Finds sending http request without context.Context [fast: false, auto-fix: false]
• sqlclosecheck: Checks that sql.Rows, sql.Stmt, sqlx.NamedStmt, pgx.Query are closed. [fast: false, auto-fix: false]
• testifylint: Checks usage of github.com/stretchr/testify. [fast: false, auto-fix: false]
• unparam: Reports unused function parameters [fast: false, auto-fix: false]